Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix browser warnings related to crossorigin preload #9984

Merged
merged 1 commit into from
Jan 25, 2020

Conversation

silverwind
Copy link
Member

I don't fully understand why Chrome would consider these requests cross-origin when they are clearly same-origin in my view. Anyways, this should get rid of the console warning. I did try with-credentials but that seemed to have no effect.

Fixes: #9976 (comment) @zeripath

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 25, 2020
@zeripath zeripath added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 25, 2020
@zeripath zeripath added this to the 1.12.0 milestone Jan 25, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 25, 2020
@codecov-io
Copy link

Codecov Report

Merging #9984 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9984      +/-   ##
==========================================
- Coverage   42.26%   42.25%   -0.02%     
==========================================
  Files         610      610              
  Lines       80370    80370              
==========================================
- Hits        33971    33960      -11     
- Misses      42221    42230       +9     
- Partials     4178     4180       +2
Impacted Files Coverage Δ
services/pull/update.go 51.16% <0%> (-3.49%) ⬇️
services/pull/patch.go 64.77% <0%> (-3.15%) ⬇️
models/unit.go 37.03% <0%> (-2.47%) ⬇️
routers/repo/view.go 38.59% <0%> (-0.88%) ⬇️
modules/queue/workerpool.go 42.48% <0%> (+1.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a83c373...1f77f6b. Read the comment docs.

@lafriks lafriks merged commit 1703a63 into go-gitea:master Jan 25, 2020
@silverwind silverwind deleted the preload-warning branch January 25, 2020 22:24
@guillep2k
Copy link
Member

I don't fully understand why Chrome would consider these requests cross-origin when they are clearly same-origin in my view.

Maybe there's a redirection in play?

@silverwind
Copy link
Member Author

No, those are direct responses. I think it's just a useless detail in that preload spec.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants