This repository has been archived by the owner on Jun 8, 2019. It is now read-only.
Functions for Collaborators #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
lunny
suggested changes
Dec 13, 2016
| @@ -10,6 +10,29 @@ import ( | |||
| "fmt" | |||
| ) | |||
|
|
|||
| // ListCollaborators list a repository's collaborators | |||
| func (c *Client) ListCollaborators(user, repo string) ([]*User, error) { | |||
There was a problem hiding this comment.
this needs pagination yes, I must've missed that one 🙁
There was a problem hiding this comment.
IMHO pager makes only sense for potentially large lists
There was a problem hiding this comment.
@tboerger having 100 collaborators isn't large enough? :)
There was a problem hiding this comment.
and seeing as it's currently locked at 10 entries per call, pagination is required if you have more than that...
There was a problem hiding this comment.
I agree pager is no need currently. But collaborators := make([]*User, 0, 10) is really not collaborators := make([]*User, 10).
lunny
suggested changes
Dec 20, 2016
| @@ -10,6 +10,29 @@ import ( | |||
| "fmt" | |||
| ) | |||
|
|
|||
| // ListCollaborators list a repository's collaborators | |||
| func (c *Client) ListCollaborators(user, repo string) ([]*User, error) { | |||
| collaborators := make([]*User, 10) | |||
There was a problem hiding this comment.
collaborators := make([]*User, 0, 10)
| @@ -10,6 +10,29 @@ import ( | |||
| "fmt" | |||
| ) | |||
|
|
|||
| // ListCollaborators list a repository's collaborators | |||
| func (c *Client) ListCollaborators(user, repo string) ([]*User, error) { | |||
ethantkoenig
force-pushed
the
collaborators
branch
from
57d9fef
to
54a391b
Compare
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functions corresponding to the following endpoints:
GET repos/:username/:reponame/collaborators: list collaboratorsGET repos/:username/:reponame/collaborators/:collaborator: check if a user is a collaboratorDELETE repos/:username/:reponame/collaborators/:collaborator: remove a collaboratorThese endpoints are implemented in go-gitea/gitea#375.