fix: association concurrently appending #6044
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
Fix bug when association concurrently appending.
Association
in each goroutine will modify the user.Languages byreflect.Append
, which method grows the slice.If it grows successfully, languages will be a new slice, that's ok.
But If cap is enough, these goroutines will write the same slice, that's wrong.
If we only call
DB.FirstOrCreate(&user)
, user.Languages len is 0 and cap is 0, that's ok.if we only call
DB.Preload("Languages").FirstOrCreate(&user)
, still len 0 and cap 0.But we call
DB.FirstOrCreate(&user)
first, thenDB.Preload("Languages").FirstOrCreate(&user)
, user.Languages is len 0 and cap 10, this error will occur #5801User Case Description