Use RawSQL instead of Create to be able to upgrade to gorm new version #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magellancl
changed the title
oxyno-zeta
reviewed
Mar 18, 2024
| @@ -458,8 +458,7 @@ func (g *Gormigrate) unknownMigrationsHaveHappened() (bool, error) { | |||
| } | |||
|
|
|||
| func (g *Gormigrate) insertMigration(id string) error { | |||
| record := map[string]interface{}{g.options.IDColumnName: id} | |||
| return g.tx.Table(g.options.TableName).Create(record).Error | |||
| return g.tx.Exec("INSERT INTO " + g.options.TableName + " (" + g.options.IDColumnName + ") VALUES ('" + id + "')").Error | |||
There was a problem hiding this comment.
This can lead to SQL Injection and prevent id to have single quote inside. Am I missing something ?
There was a problem hiding this comment.
It's not much of a PR, more like the draft of a possible fix to get some feedback
There was a problem hiding this comment.
Just saw you made one at the same time, I'm closing this one
There was a problem hiding this comment.
Oh I see ! No problem, I was just looking as I saw your PR just after I did one ahah.
|
@magellancl Thank you for your time and contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#217
Making a PR to support the latest gorm upgrade because the gorm fix doesn't seem to be coming anytime soon.
I did this quickly, but I am a bit wary of potential SQL injection, any review is welcome.