Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing: easy way to discard logs #228

Closed
System-Glitch opened this issue Sep 19, 2024 · 0 comments
Closed

Testing: easy way to discard logs #228

System-Glitch opened this issue Sep 19, 2024 · 0 comments
Labels
contributions welcome Looking for contributors enhancement Enhancement of existing feature good first issue Good for newcomers

Comments

@System-Glitch
Copy link
Member

Proposal

Add a slog.Discard logger that outputs to io.Discord. This will make test servers easier to generate:

server := testutil.NewTestServerWithOptions(t, goyave.Options{Logger: slog.Discard)})

Maybe use the discard logger by default in test servers.
@System-Glitch System-Glitch added enhancement Enhancement of existing feature good first issue Good for newcomers contributions welcome Looking for contributors labels Sep 19, 2024
@SallesCosta SallesCosta mentioned this issue Sep 20, 2024
Merged
System-Glitch pushed a commit that referenced this issue Sep 22, 2024
@SallesCosta
#228 - Feat: create slog discard logger (#229)
007c11e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contributions welcome Looking for contributors enhancement Enhancement of existing feature good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@System-Glitch