#215 - Response: add support for flushing #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
System-Glitch
force-pushed
the
feature/flusher
branch
from
c25fc94 to
8c0796b
Compare
Pull Request Test Coverage Report for Build 9910117267Details
💛 - Coveralls |
ccoVeille
reviewed
Jul 12, 2024
- Response implement http.Flusher - Call PreWrite only once on the first Write - Add CommonWriter to reduce chained writers boilerplate - Use CommonWriter for log and compress middleware
System-Glitch
force-pushed
the
feature/flusher
branch
from
8c0796b to
f68b0c6
Compare
System-Glitch
changed the title
|
Awesome, This is exactly what I need right now! |
ccoVeille
approved these changes
Jul 16, 2024
| // be called with an empty byte slice. | ||
| func (r *Response) Flush() { | ||
| if !r.wroteHeader { | ||
| r.PreWrite([]byte{}) |
There was a problem hiding this comment.
I'm a bit surprised by this line, because it will call prewrite, that will indeed send the header, but I feel strange to PreWrite during flush
Shouldn't you simply call WriteHeader ?
Suggested change
| r.PreWrite([]byte{}) | |
| r.WriteHeader(r.status) |
There was a problem hiding this comment.
A flush will trigger a write so we want to trigger PreWrite as well. It's only relevant if you call Flush without having written anything (no prior call to Write).
Comment on lines
147
to
149
| if !r.wroteHeader { | ||
| if r.status == 0 { | ||
| r.status = http.StatusOK |
There was a problem hiding this comment.
Suggested change
| if !r.wroteHeader { | |
| if r.status == 0 { | |
| r.status = http.StatusOK | |
| if !r.IsHeaderWritten { |
There was a problem hiding this comment.
I would move the check if 0, then OK into r.WriteHeader
if status == 0 {
status = http.StatusOK
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Issue(s): closes #215
Description
Responseimplementhttp.FlusherPreWriteonly once on the firstWriteCommonWriterto reduce chained writers boilerplateCommonWriterfor log and compress middleware