feat(functions): add a config option to pass consolidateBy to the storage backend #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adding names to fields allows addition of other fields to MetricRequest without breaking backwards compatibility
almostinf
reviewed
Apr 12, 2024
Civil
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mostly a copy of #793.
Passes consolidateBy with its argument to the backend through the FilteringFunctions field. Only works with carbonapi_v3_pb protocol.
Fixes broken tests and removes passing ConsolidationFunc field further after parsing the target in Fetch. This is needed since this field is empty during evaluation and "values" map will not return anything.
In addition I added an option to the config to enable this behavior.