Systemd improvements: start after network/fs online and allow more open files #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without these go-carbon can start before the network is online and also before all local fses have been mounted. If /var/lib/carbon is on a separate disk, this can lead to a failed start because the go-carbon will start, begin writing to the empty dir, then the carbon FS will not mount due to it not being empty. Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch>
By default we should allow more open files to allow for large installations. Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch>
|
Not sure those failures are related. |
|
Indeed, looks like unrelated. I'll merge and fix tests later. Thank for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where go-carbon would start before the whisper data dir was mounted, leading to boot issues.
Also network-online.target is the correct thing to be After and Want.
Lastly, allow more open files to enable larger installations OOTB.