receiver/kafka: error handling fixes #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtition Clients and consumers are not closed when consumer.ConsumePartition failed, which creates a resource leaks. If the error is sticky due to bad offset saved in state file, the receiver would keep creating new consumer connections and not closing them. This commit fixes the issue, by making sure the connections and consumers are closed if there is errors when trying to consume a partition. At the same time, if an sarama.ErrOffsetOutOfRange error is returned, it would just falls back to oldest offset, instead of keep retrying.
It is not necessary to create new ticker in every loop.
deniszh
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes for issue #412.
receiver/kafka: fix kafka connection leaks when it fails to consume partition
Clients and consumers are not closed when consumer.ConsumePartition failed, which creates a resource leaks. If the error is sticky due to bad offset saved in state file, the receiver would keep creating new consumer connections and not closing them.
This commit fixes the issue, by making sure the connections and consumers are closed if there is errors when trying to consume a partition.
At the same time, if an sarama.ErrOffsetOutOfRange error is returned, it would just falls back to oldest offset, instead of keep retrying.
moves time.NewTicker out of for loop