trie: stop indexing empty directory nodes #445
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a strange bug in trie that seems related to indexing empty directory nodes.
The actual root causeIn our production, we notice the issue associatesis still unknown to me and I fail to reproduce the issue.
with a cron job for removing files (which would causes the generation of empty directories).
Considering that empty directories doesn't produce much value in go-carbon/graphite, excluding it from
index should cause no harm. And this change also appears to resolve the issue on our production.
Edit:
The bug has been identified and fixed in this commit. But I'm still keeping the changes of excluding empty directories from the trie index as overall, it should be a good change: