Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find grpc #488

Merged
merged 4 commits into from
Aug 26, 2022
Merged

Find grpc #488

merged 4 commits into from
Aug 26, 2022

Conversation

emadolsky
Copy link
Contributor

This PR introduces find gRPC alongside unary interceptors which share a lot of logic from already implemented stream interceptors. Some minor refactors have been applied in order to reduce code copy.

Notes:

  • The same cache logic as the HTTP implementation is used for gRPC. However, because of the data compatibility, and to avoid unnecessary Marshal/Unmarshal the cache space for grpc-find and regular find are separated.
  • getWithCache function is implemented to simplify the caching code and to avoid partial fixes happened before because of the code duplication in the future.
  • There are still bunch of duplicated codes around the ratelimiter handlers (middleware, interceptor), but I let them be for now. If the reviewers believe it's better to refactor those parts as well, I'll spend some time on it.

@emadolsky emadolsky mentioned this pull request Aug 25, 2022
@emadolsky emadolsky merged commit b960542 into master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants