Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple cache for grpc render #492

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Add simple cache for grpc render #492

merged 1 commit into from
Sep 1, 2022

Conversation

emadolsky
Copy link
Contributor

No description provided.

deniszh
deniszh approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@deniszh deniszh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline, because I didn't really understand how streaming makes sense together with caching, so - it doesn't, but we need to implement caching now to fix performance issue and fix it later.

@emadolsky emadolsky merged commit 188af34 into master Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deniszh deniszh deniszh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emadolsky @deniszh