Decrease gRPC streaming channel size #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go allocates the memory for the capacity given while initializing the channels. Therefore, having a big channel can cost a lot. This commit decreases the channel size. However, it is probably better to determine the size dynamically, and by the result of glob expansion. So this commit also adds one more field to tle to help find a logic for setting the size of the channel.
azhiltsov
approved these changes
Feb 8, 2023
timtofan
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go allocates the memory for the capacity given while initializing the channels. Therefore, having a big channel can cost a lot. This commit decreases the channel size. However, it is probably better to determine the size dynamically, and by the result of glob expansion. So this commit also adds one more field to tle to help find a logic for setting the size of the channel.