finder: restrict seriesByTag (require minimum non-wildcarded eq arguments) #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msaf1980
force-pushed
the
finder_restrict_seriesByTag
branch
from
514fbad
to
0f5a7a1
Compare
msaf1980
added a commit
to msaf1980/graphite-clickhouse
that referenced
this pull request
Mar 21, 2023
msaf1980
added a commit
to msaf1980/graphite-clickhouse
that referenced
this pull request
Mar 27, 2023
msaf1980
added a commit
to msaf1980/graphite-clickhouse
that referenced
this pull request
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On large setup some requests like
seriesByTag('name=~test.*.*.rabbitmq_overview.connections')orseriesByTag('name=test.*.*.rabbitmq_overview.connections')may be too costly. Yes, this a bad pattern, but we need a way restrict bad queries before execution query and max_read_rows limit for reduce database load.