Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: convert to go:build directives #798

Closed
2 tasks done
sbinet opened this issue Sep 3, 2020 · 2 comments · Fixed by #927
Closed
2 tasks done

all: convert to go:build directives #798

sbinet opened this issue Sep 3, 2020 · 2 comments · Fixed by #927

Comments

@sbinet
Copy link
Member

sbinet commented Sep 3, 2020

as mentioned in golang/go#41184, Go will probably migrate to a more robust build constraints directive, as explained there:

we should prepare for that:

  • for Go-1.17: add all //go:build directives
  • for Go-1.18: remove all // +build directives
@rsc
Copy link

rsc commented Sep 16, 2020

Please wait until Go 1.17 to add any //go:build directives.
Go 1.16 is only setting up for Go 1.17. Go 1.17 is the real change.

@sbinet
Copy link
Member Author

sbinet commented Sep 16, 2020

Thanks for pointing this out.
I've modified the planned timeline.

sbinet added a commit to sbinet-hep/hep that referenced this issue Feb 25, 2021
Updates go-hep#798.

Signed-off-by: Sebastien Binet <binet@cern.ch>
@sbinet sbinet added the go-1.18 label Feb 21, 2022
sbinet added a commit to sbinet-hep/hep that referenced this issue Mar 22, 2022
@sbinet sbinet closed this as completed in 6c35963 Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants