-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --passwordsource global option #442
base: master
Are you sure you want to change the base?
Conversation
@@ -48,3 +48,5 @@ require ( | |||
gopkg.in/op/go-logging.v1 v1.0.0-20160211212156-b2cb9fa56473 | |||
gopkg.in/yaml.v2 v2.2.2 // indirect | |||
) | |||
|
|||
replace github.com/go-jira/jira => github.com/chuckliu1979/jira v1.0.30 //indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, this probably shouldn't stay in.
replace github.com/go-jira/jira => github.com/chuckliu1979/jira v1.0.30 //indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 we can't merge with this in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix the replace
line in go.mod at least. Did not review the rest.
for automation testing and/or CI/CD, it's good to have pipe login from stdin. at present we need add "password-source: stdin" in .jira.d/config.yml, it's not convenient. this pull request would better :
echo "password" | jira login --passwordsource stdin