Add Windows (and update Linux) keyring support with zalando/go-keyring #467
+20
−31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces tmc/keyring (who's latest commit was in 2017) with zalando/go-keyring to update go-jira's keyring support.
go-keyring
is:password-source: keyring
godbux/dbus/v5
)This PR is an alternative to #460 (also see #459) for the reasons above and doesn't require @dougEfresh to maintain a fork. I meant to do this far sooner, but my son was born early!
Testing
I tested on MacOS and Windows with the following config:
and the commands: