Use a concrete type for JSON pointer #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbrandhorst
approved these changes
Apr 12, 2024
|
I can imagine the following: func (*Encoder) WriteTokens(seq iter.Seq2[Token, error]) error
func (*Decoder) ReadTokens() iter.Seq2[Token, error]but that can be future API. |
ChrisHines
reviewed
Apr 12, 2024
mvdan
approved these changes
Apr 18, 2024
| // Use of this source code is governed by a BSD-style | ||
| // license that can be found in the LICENSE file. | ||
|
|
||
| //go:build goexperiment.rangefunc |
There was a problem hiding this comment.
at this point I would personally use //go:build go1.23 and test with Go master or the first pre-release once it's out, which should be soon. Ideally we would use goexperiment.rangefunc || 1.23, but that's broken because of golang/go#66399. With your build tag as is, any 1.23 users can't see this API, which isn't right.
There was a problem hiding this comment.
At present, the iter package has the goexperiment.rangefunc tag, so go1.23 isn't enough. It's not clear to me whether the intent is to have iterators be directly supported in Go 1.23. For now I'll submit it with the current tag and we can adjust it accordingly based on what happens upstream.
WARNING: This commit includes breaking changes. Declare a jsontext.Pointer type as a named string type. This allows us to implement a Tokens method to conveniently iterate over all the reference tokens in the pointer using the upcoming iterators support. The new functionally is currently not tested by CI, but can be manually tested with: GOEXPERIMENT=rangefunc go.tip test ./...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: This commit includes breaking changes.
Declare a jsontext.Pointer type as a named string type.
This allows us to implement a Tokens method to conveniently iterate over all the reference tokens in the pointer using the upcoming iterators support.
The new functionally is currently not tested by CI, but can be manually tested with: