Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RestartTask function #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chris-vest
Copy link

As per the Confluent documentation, the connectors/$name/restart endpoint only restarts the Connector, but not the Connector's tasks. There is a separate endpoint for restarting tasks by task ID.

Thanks for reviewing my PR!

@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #9 into master will increase coverage by 0.30%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   87.39%   87.70%   +0.30%     
==========================================
  Files           3        3              
  Lines         119      122       +3     
==========================================
+ Hits          104      107       +3     
  Misses          9        9              
  Partials        6        6              
Impacted Files Coverage Δ
connectors.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 759c155...a5331ec. Read the comment docs.

@chris-vest
Copy link
Author

I've noticed there's another PR open which adds this function plus some other useful ones - it doesn't look like the author of that PR is going to work on it any longer. I am happy to finish it off according to your comments on his PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant