Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transport/http: ability to log response headers, response size, etc. #460

Closed
peterbourgon opened this issue Feb 10, 2017 · 0 comments
Closed

transport/http: ability to log response headers, response size, etc. #460

peterbourgon opened this issue Feb 10, 2017 · 0 comments
Labels
enhancement

Comments

@peterbourgon
Copy link
Member

peterbourgon commented Feb 10, 2017 •
edited
Loading

With transport/http.ServerFinalizerFunc, it's possible to log a lot of information about the incoming request—especially when combined with transport/http.PopulateRequestContext.

Using the same mechanism, we can log the status code of the response. But it would be great to capture a lot more information about the response, at a minimum the response headers and the response body size.

/cc @xla
peterbourgon added a commit that referenced this issue Feb 10, 2017
@peterbourgon
transport/http: provide more response details
9a2a6a5 
ServerFinalizerFunc gets access to response headers and size.
Closes #460.
@peterbourgon peterbourgon mentioned this issue Feb 10, 2017
Merged
peterbourgon added a commit that referenced this issue Feb 10, 2017
@peterbourgon
transport/http: provide more response details
816c73e 
ServerFinalizerFunc gets access to response headers and size.
Closes #460.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peterbourgon