Should not set header after WriteHeader in example
#537
Comments
bcho
added a commit
to bcho/kit
that referenced
this issue
May 26, 2017
From `net/http`:
Changing the header map after a call to WriteHeader (or Write)
has no effect unless the modified headers are trailers.
To send the `content-type`, need to set before calling `WriteHeader`.
Fixes go-kit#537
jamesgist
pushed a commit
to jamesgist/kit
that referenced
this issue
Nov 1, 2024
From `net/http`:
Changing the header map after a call to WriteHeader (or Write)
has no effect unless the modified headers are trailers.
To send the `content-type`, need to set before calling `WriteHeader`.
Fixes go-kit#537
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In shipping example: https://github.com/go-kit/kit/blame/master/examples/shipping/booking/transport.go#L184
encodeErrormay write header before setting thecontent-typeheader. From go net/http's doc:Seems like the
content-typeheader should set before the error switch.The text was updated successfully, but these errors were encountered: