Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transport/http: Strange phrase in NewServer documentation. #560

Closed
dmitshur opened this issue Jun 29, 2017 · 2 comments
Closed

transport/http: Strange phrase in NewServer documentation. #560

dmitshur opened this issue Jun 29, 2017 · 2 comments

Comments

@dmitshur
Copy link

http.NewServer documentation says:

// NewServer constructs a new server, which implements http.Server and wraps
// the provided endpoint.

I don't understand what it means by "implements http.Server". http.Server is a struct. Is there a typo in the documentation?

@groob
Copy link
Contributor

groob commented Jun 29, 2017

It implements the Handler interface. I agree this looks like an oversight.

@dmitshur
Copy link
Author

Thanks for resolving this issue @peterbourgon! Now it makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants