Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not always override operation name when tracing endpoints #615

Closed
embs opened this issue Sep 21, 2017 · 3 comments
Closed

Do not always override operation name when tracing endpoints #615

embs opened this issue Sep 21, 2017 · 3 comments

Comments

@embs
Copy link

embs commented Sep 21, 2017

I'd like the operation name not to get overwritten in a server span when it's already set by the client who is calling the endpoint -- which is the case when using same span for client/server, like here: microservices-demo/user#53

I guess this behavior could be achieved by modifying

serverSpan.SetOperationName(operationName)

Maybe we could add some conditional logic to set operation name only if the span isn't being shared between client/server? (I'm afraid this could be Zipkin-specific though)

Does that make sense? I would gladly try fixing up a PR if it does.

@basvanbeek
Copy link
Member

basvanbeek commented Sep 21, 2017

it is Zipkin specific and Zipkin standard behavior. Also worth mentioning is the fact that Zipkin is moving away from client / server shared spans with V2.

@yurishkuro
Copy link
Contributor

it is illegal to start a span via OpenTracing API without an operation name. Also it is generally a bad idea trusting the client to name your server endpoint, the server is the authority.

btw, Jaeger (http://github.com/uber/jaeger), recently accepted to CNCF, does not mix client/server spans, if you want to try it out.

@embs
Copy link
Author

embs commented Sep 25, 2017

Thank you for your kind suggestions and explanations.

I'll try moving towards using single-host spans, then.

@embs embs closed this as completed Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants