This repository has been archived by the owner on Dec 5, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also reuse client span to be consistent with how interactions betweenUPDATE: removed as Zipkin is moving away from client/server shared spans: openzipkin/zipkin#939Java services are traced.
Related to microservices-demo/orders#48
An example of how these changes affect traces:
Before modification
Complete trace: original.zip
After modification
Complete trace: after-modification.zip
The highlighted frames in second image refers to:
1 and 3 are not huge problems but I'm working on them in order to achieve consistence with how Java <-> Java services interactions are traced.