Logrus adapter for Logger

[AlmogBaku]

I suggest we'll provide a Logrus adapter for our log interface.

This adapter will mainly be used to support features of gokit, i.e. "gokit's http-server logging"

[AlmogBaku]

simple example:

type serverLogger struct {
	*logrus.Entry
}
func (l serverLogger) Log(keyvals ...interface{}) error {
	if len(keyvals)%2 == 0 {
		logger := l.Entry
		for i := 0; i < len(keyvals); i += 2 {
			logger = logger.WithField(fmt.Sprint(keyvals[i]), keyvals[i+1])
		}
		logger.Error()
	} else {
		l.Error(keyvals)
	}
	return nil
}

[aswinmprabhu]

I am new to Golang and this is my attempt at this issue. Any feedback would be appreciated.

[AlmogBaku]

In the meanwhile, you can use the code I attached above. I'll send a PR later on

[aswinmprabhu]

I would like to make a PR and contribute.
Shall I write tests and make a PR?

[ChrisHines]

I would like to understand more about the rationale behind writing a log.Logger implementation backed by logrus. Should we instead add features to support some specific logrus behavior more directly in the go-kit/log/... packages? If the desire is simply to make logrus implement the log.Logger interface, does that belong in go-kit, in logrus, or somewhere else? Why?

[AlmogBaku]

In our use-case, we decided to use logrus organization-wide. However, we using some components of go-kit(such as kithttp.NewServer) which require a kit.logger.

I think it would make sense to provide as a part of the kit an adapter for logrus (like we have adapters for other stuff here)

[dytomode]

go-kit http server only requires for a logger to implement this interface.

type Logger interface {
	Log(keyvals ...interface{}) error
}

You can use any struct you want if it has Log(keyvals ...interface{}) error
I don't see why logrus should be added to go-kit.

[AlmogBaku]

I'm not suggesting to use Logrus, but to provide an adapter to our logger.
See the code here I attached above as a reference.

[ChrisHines]

I am willing to review a PR that adds a package with a logrus adapter. Suggestions for the package path:

• github.com/go-kit/kit/log/logrus
• github.com/go-kit/kit/log/kitlogrus

[aswinmprabhu]

I will make a PR after writing the tests