Move the ClientAfter calls to before the decode #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClientAfter is documented as running _prior_ to being decoded. But, this was only partly true. They were run prior to decode, but after the jsonrpc unmarshalling, As the callback uses the bare response object, and at least for me, is used to debug what's seen on the wire, this seems incorrect.
|
Sounds good. Can you add a test which fails before this change and succeeds afterwards? |
|
Okay! I added tests. Also did some cleanup on that test file:
|
|
Hi! I wanted to check in on this? |
|
Apologies for the delay. Looks good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClientAfter is documented as running prior to being decoded. But, this
was only partly true. They were run prior to decode, but after the
jsonrpc unmarshalling,
As the callback uses the bare response object, and at least for me, is
used to debug what's seen on the wire, this seems incorrect.
This oddity does not exist in other transports, as there is not the duplicate decode step.