Update Go versions for CI (v2) #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbourgon
force-pushed
the
go-version-update-2
branch
from
706d2c6 to
27ff38c
Compare
| @@ -12,7 +12,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| go: ['1.13', '1.14'] | |||
| go: ['1.14', '1.15'] | |||
There was a problem hiding this comment.
curious and feel free to not answer if busy. what would make you decide to extend the range to 1.16? and if so, would you lift the floor also?
There was a problem hiding this comment.
Well, 1.16 wasn't released when I made this change :)
There was a problem hiding this comment.
And yes, the intent is to have this track the currently supported Go versions, which are the current version and the previous version, so technically should be 1.15 and 1.16, now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaner version of #1030.