-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relocate examples to a separate repository #1100
Conversation
ce33e0c
to
ad1f50c
Compare
Sorry, no. But breaking examples out to a separate repo + module would be fine! |
Do you want to preserve history (similar to the log module)? IMHO it's not that important for examples, but I can prepare a separate repo with the history preserved if you prefer that way. |
The benefit of reducing the dependencies of |
I prepared a repository here: https://github.com/sagikazarmark/kit-examples I added you both as collaborators I opened a PR with the necessary changes to make the repo functional: go-kit/examples#1 I'd suggest merging the PR if you are satisfied with the changes and then transferring (and renaming) the repo. |
Is it possible to transfer a repo in this way? Any docs? Never done it before. |
It's actually quite easy to do: |
b2d6a85
to
b0fcdad
Compare
Repurposed this PR to relocate examples to a separate repository. Should be merged once https://github.com/sagikazarmark/examples is moved to go-kit. |
@peterbourgon GitHub doesn't allow me to move the repo: go-kit/examples#1 (comment) :
|
b0fcdad
to
9579d21
Compare
So after reading the documentation, I need permission to create repos which I don't have at the moment. @peterbourgon if you trust that I'm not going to abuse my new powers, you can give me repo create permission temporarily. The alternative is what I wanted to do originally: I transfer the repo to you and you can transfer it to the go-kit organization. |
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
9579d21
to
37dda2e
Compare
Apologies for the delay. I should be back up and running at full capacity in about 2 weeks. You should be able to create repos now, @sagikazarmark — can you confirm? |
Yep, thanks @peterbourgon. No worries! The repo is moved here: https://github.com/go-kit/examples If you are all happy with the result, we can merge this PR as well. |
Repurposed this PR to relocate examples to a separate repository.
Should be merged once https://github.com/sagikazarmark/examples is moved to go-kit.
This PR is a proof of concept of how a separate examples module would look like. Although submodules in a single repo are discouraged, this module is not supposed to be used as a dependency in other modules, so it should be fine. (The alternative would be moving examples to a separate repo, but I don't think that's a good idea)
The advantage of making the examples package a separate module is that the root module can get rid of quite a few dependencies only used in examples.
Some disadvantages of making this move:
The biggest risk is an ambiguous import path error, but it should be fine as long as people don't import the examples package (I think) which they shouldn't anyway. The alternative is renaming the package to something else.
go get
ting the go-kit package will no longer download the examples, so any documentation will have to be updated. However, every since go modules,go get
is no longer the primary way to download the source code for a module, so this shouldn't be a problem either.Last, but not least: updating dependencies would become somewhat redundant (common dependencies need to be updated in both modules)
In my opinion, the benefits outweigh the costs.
WDYT? @peterbourgon @ChrisHines