go.mod | go.sum: update dependencies for prometheus client_golang #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What version of Go and what commands did you use to create this PR? The changes here seem too extensive for upgrading one module. I am especially surprised to see some modules move to older versions. I seem to get much more modest changes with Go 1.18 and these commands: |
|
Sorry, rookie mistake, I mess up with the github.com/prometheus/common indirect dependency, but that change is unnecessary and invasive, and your approach solve the vulnerability. I just commit that. |
|
OK. Thanks for the updates. I'm kicking off the builds. |
ChrisHines
approved these changes
Apr 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dependency for vulnerability on https://nvd.nist.gov/vuln/detail/CVE-2022-21698
Issue: #1224