Updated kit/tracing readme's and removed deprecated kit/tracing/zipkin package #275
Conversation
| `tracing/zipkin` package is now deprecated. In the `kit/tracing/zipkin` | ||
| directory you can still find the `docker-compose` script to bootstrap a Zipkin | ||
| development environment and a [README] detailing how to transition from the | ||
| old package to the new. |
There was a problem hiding this comment.
Clear and concise explanation. Perfect. Thank you.
|
|
|
Thoughts on having a |
|
For a full example of how the OpenTracing middleware should be wired we have an updated Can you elaborate on what in your mind is currently lacking in documenting the change so we can improve this PR if needed? |
| // let's annotate the end... | ||
| span.LogEvent("query:end") | ||
|
|
||
| // we're done with the span. send it to the SpanRecorder for collection... |
There was a problem hiding this comment.
FYI, the OpenTracing spec doesn't address what happens to Spans after they are Finish()ed... (basictracer might, but that's just a convenience repo for folks implementing tracing systems)
There was a problem hiding this comment.
This is how the Zipkin implementation works and that's the scope of this document, but I'll leave it out if it would confuse people.
|
updated the zipkin readme regarding span per node vs span per rpc. |
|
Excellent. LGTM. I'll let you merge as you have the contributor bit now. |
Updated kit/tracing readme's and removed deprecated kit/tracing/zipkin package
I've removed the deprecated
kit/tracing/zipkin packagebut have left the folder available. The folder now has some explanation on how to transition from our legacy Zipkin package to OpenTracing and it remains to hold thedocker-composescript for getting a Zipkin back-end bootstrapped quickly for development.