Fix: TraceClient crashed in absense of a parentSpan in Context #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to write a previously-failing, now-succeeding test for this? |
|
This was a dumb oversight on my end while refactoring from old to new API. The old api allowed you to drop in a span itself which was allowed to be nil. I now have to actually dereference the span (so it must exist) to get to its Context property. Not sure what an extra test would help with |
|
Added test to safeguard from regressions... |
Added TestTraceClientNoContextSpan to test for this situation
|
Confirmed test fails on current master. LGTM! |
jamesgist
pushed a commit
to jamesgist/kit
that referenced
this pull request
Nov 1, 2024
Fix: TraceClient crashed in absense of a parentSpan in Context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yeah that's unfortunate... we used to not care if parentSpan existed or not but since we now dereference the SpanContext we must test for it...