transport/http: enhance the DefaultErrorEncoder #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbourgon
force-pushed
the
enhanced-error-encoder
branch
3 times, most recently
from
8df4476 to
520cf55
Compare
- Errors may implement StatusCoder interface - Errors may implement Headerer interface - Errors may implement json.Marshaler interface
With sane defaults.
This RequestFunc moves many HTTP request parameters to the context under specific keys. If wired in to the transport, those values are available to subsequent endpoints or service methods that receive the context. This can be used to e.g. log transport (HTTP) details in a service logging middleware.
peterbourgon
force-pushed
the
enhanced-error-encoder
branch
from
b608fa9 to
8599541
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides another mechanism for mapping business-domain errors to transport-domain serialization. It should also help with an upcoming basicauth package.