log: Update NewSyncWriter to work with term.IsTerminal. #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the approach. |
|
@ChrisHines I like it too. |
- Change the return type to io.Writer - Return an io.Writer that also has the `Fd() uintptr` method of the wrapped io.Writer if present.
jamesgist
pushed a commit
to jamesgist/kit
that referenced
this pull request
Nov 1, 2024
log: Update NewSyncWriter to work with term.IsTerminal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fd() uintptrmethod of thewrapped io.Writer if present.
Fixes #483 as an alternate approach to #482.
What do you think of this approach @ereOn & @peterbourgon?