Track gauge values and support default tags for dogstatsd #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dogstatsd doesn't support sending deltas for gauges, so we must maintain the raw gauge value ourselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dogstatsd doesn't support deltas for gauges, so we must maintain the raw gauge value ourselves.
lv.Spaces don't support carrying over values from previous flush periods, so this implementation duplicateslv.Space's label value tree logic to map toGauges rather than observations. The simpler implementation of https://github.com/go-kit/kit/blob/master/metrics/graphite/graphite.go#L69 won't fly here because Dogstatsd supports tags, and we need to return the sameGaugeevery time for a given (name, lvs...) tuple. The changes also add tracking for whether a gauge was written in a flush period to avoid sending every gauge value every time.Also adds support for the tag analogue of the prefix parameter to
dogstatsd.New.#578