#614 add casbin for authorization #787
Conversation
|
Hi @peterbourgon, the tests failed on metrics/pcp - TestInconsistentLabelCardinality, it should be unrelated with this PR (auth/casbin) can help to advise how should we continue ? |
|
Oh cool! Ignore the error, I'll fix it up. Primary review comment right now, please fix up all the doc comments to be valid English sentences with capitalization and punctuation, word-wrapped at 80 columns. |
|
If you rebase the test errors should go away. |
|
thanks @peterbourgon, the pcp is good now but the circleci got err on sd/etcdv3 integration test part |
auth/casbin/middleware.go
Outdated
| const ( | ||
| // CasbinModelContextKey holds the key to store the access control model | ||
| // in context, it can be a path to configuration file or a casbin/model | ||
| // Model |
There was a problem hiding this comment.
Still need punctuation etc. on all doc comments like this one.
There was a problem hiding this comment.
submitted and update, would it be like that ? sorry kinda new into this.
|
Thanks! |
Enhancement #614
Add into the middleware: casbin
Design to be review are
authdirectory the right place to put casbinany further feedback please help to add, thanks !
Disclaimer -- testdata are actually taken from casbin repository test