adds request sampler into zipkin tracing. #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcchavezs
commented
Dec 14, 2018
| @@ -27,7 +27,7 @@ const ( | |||
| testTagValue = "test_value" | |||
| ) | |||
|
|
|||
| func TestHttpClientTracePropagatesParentSpan(t *testing.T) { | |||
| func TestHTTPClientTracePropagatesParentSpan(t *testing.T) { | |||
There was a problem hiding this comment.
Http -> HTTP, not too important for this PR.
|
Not sure how my change is related to the current failure. Could we have a retrigger? |
|
Can we please merge this @basvanbeek @peterbourgon ? |
basvanbeek
reviewed
Jan 1, 2019
tracing/zipkin/http.go
Outdated
| @@ -156,6 +156,12 @@ func HTTPServerTrace(tracer *zipkin.Tracer, options ...TracerOption) kithttp.Ser | |||
|
|
|||
| if config.propagate { | |||
| spanContext = tracer.Extract(b3.ExtractHTTP(req)) | |||
|
|
|||
| if config.requestSampler != nil && spanContext.Sampled == nil { | |||
There was a problem hiding this comment.
minor item... please swap the tested conditions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #812
Ping @basvanbeek