-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a log adapter for zap.Logger #855
Conversation
@peterbourgon done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have some test cases that probe the edge cases of the varargs kv
passed to Log
. Otherwise I made a few comments about readability.
@ChrisHines Hi, I rewrote the test according to your suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more improvement then we're good.
@ChrisHines ok, use subtests now, test output
|
@MaruHyl Thanks for the contribution! |
For #854