-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use koanf instead of viper #261
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #261 +/- ##
==========================================
- Coverage 86.33% 86.03% -0.30%
==========================================
Files 41 41
Lines 2729 2729
==========================================
- Hits 2356 2348 -8
- Misses 273 279 +6
- Partials 100 102 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I'm unsure about the PR idea. I mean this PR seems to get out the blue. What are you trying to solve ? Why using koanf instead of viper on this project ? what could it bring ? Thanks Please note I'm not suspicious or sarcastic, I'm simply clueless I'm a random Gopher, following the project |
@ccoVeille Thanks for you attention, I prefer to koanf with less dependencies and more stable interface for multiple/dynamic/remote config support. And in the near future, kod just need rely on koanf's interface for configs, after supporting WithConfigProvider(p koanf.Provider) :-) |
Thanks |
Did you try using @Zxilly (hi 👋) tool on your code to see the difference of size? |
No description provided.