Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use koanf instead of viper #261

Merged
merged 5 commits into from
Dec 23, 2024
Merged

feat: use koanf instead of viper #261

merged 5 commits into from
Dec 23, 2024

Conversation

sysulq
Copy link
Contributor

@sysulq sysulq commented Dec 13, 2024

No description provided.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 80.76923% with 5 lines in your changes missing coverage. Please review.

Project coverage is 86.03%. Comparing base (0ad279d) to head (097273f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
kod.go 80.00% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
- Coverage   86.33%   86.03%   -0.30%     
==========================================
  Files          41       41              
  Lines        2729     2729              
==========================================
- Hits         2356     2348       -8     
- Misses        273      279       +6     
- Partials      100      102       +2     
Flag Coverage Δ
unittests 86.03% <80.76%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ccoVeille
Copy link
Contributor

I'm unsure about the PR idea.

I mean this PR seems to get out the blue.

What are you trying to solve ?

Why using koanf instead of viper on this project ?

what could it bring ?

Thanks

Please note I'm not suspicious or sarcastic, I'm simply clueless

I'm a random Gopher, following the project

@sysulq
Copy link
Contributor Author

sysulq commented Dec 20, 2024

@ccoVeille Thanks for you attention, I prefer to koanf with less dependencies and more stable interface for multiple/dynamic/remote config support.

And in the near future, kod just need rely on koanf's interface for configs, after supporting WithConfigProvider(p koanf.Provider) :-)

@sysulq
Copy link
Contributor Author

sysulq commented Dec 20, 2024

@ccoVeille
Copy link
Contributor

Thanks

@sysulq sysulq merged commit 7953a80 into main Dec 23, 2024
8 of 10 checks passed
@sysulq sysulq deleted the feat/koanf branch December 25, 2024 10:52
@ccoVeille
Copy link
Contributor

Did you try using @Zxilly (hi 👋) tool on your code to see the difference of size?

https://github.com/Zxilly/go-size-analyzer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants