Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): Support colon as default value in config.yaml #1332

Merged
merged 1 commit into from
Aug 14, 2021

Conversation

bakjos
Copy link
Contributor

@bakjos bakjos commented Aug 13, 2021

Description (what this PR does / why we need it):

This PR fixes a bug where the default variable of a config option was trimmed when a colon was found

Which issue(s) this PR fixes:

fixes #

Other special notes for reviewer:

@codecov-commenter
Copy link

Codecov Report

Merging #1332 (9dae96c) into main (4b6ab21) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1332   +/-   ##
=======================================
  Coverage   63.05%   63.05%           
=======================================
  Files          61       61           
  Lines        2823     2823           
=======================================
  Hits         1780     1780           
  Misses        895      895           
  Partials      148      148           
Impacted Files Coverage Δ
config/options.go 89.09% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b6ab21...9dae96c. Read the comment docs.

@tonybase tonybase merged commit 9a6c03a into go-kratos:main Aug 14, 2021
zouyx pushed a commit to zouyx/kratos that referenced this pull request Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants