Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(encoding/form): FieldMask are converted to/from lower-camel naming conventions. #1724

Merged
merged 1 commit into from
Dec 28, 2021

Conversation

tonybase
Copy link
Member

@tonybase tonybase commented Dec 28, 2021

// The JSON representation for a FieldMask is a JSON string where paths are
// separated by a comma. Fields name in each path are converted to/from
// lower-camel naming conventions. Encoding should fail if the path name would
// end up differently after a round-trip.

references: https://github.com/protocolbuffers/protobuf-go/blob/master/encoding/protojson/well_known_types.go#L842

@codecov-commenter
Copy link

Codecov Report

Merging #1724 (a1f4b1d) into main (b6b9508) will decrease coverage by 0.05%.
The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1724      +/-   ##
==========================================
- Coverage   81.20%   81.14%   -0.06%     
==========================================
  Files          78       78              
  Lines        3442     3469      +27     
==========================================
+ Hits         2795     2815      +20     
- Misses        444      449       +5     
- Partials      203      205       +2     
Impacted Files Coverage Δ
encoding/form/form.go 67.56% <66.66%> (ø)
encoding/form/proto_encode.go 72.00% <75.00%> (+0.18%) ⬆️
encoding/form/proto_decode.go 53.88% <78.57%> (+1.22%) ⬆️
transport/http/binding/encode.go 79.48% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6b9508...a1f4b1d. Read the comment docs.

Copy link
Member

@shenqidebaozi shenqidebaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenqidebaozi shenqidebaozi changed the title fix FieldMask are converted to/from lower-camel naming conventions. fix(encoding/form): FieldMask are converted to/from lower-camel naming conventions. Dec 28, 2021
@daemon365 daemon365 merged commit 11a6120 into main Dec 28, 2021
@daemon365 daemon365 deleted the fix-form-fieldmask branch December 28, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants