Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(registry/consul):fix can't get service instance in async mode #1731

Merged
merged 2 commits into from
Jan 1, 2022

Conversation

letian0805
Copy link

Description (what this PR does / why we need it):

Which issue(s) this PR fixes (resolves / be part of):

fixes #1727 problem 2

Other special notes for reviewer:

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2021

Codecov Report

Merging #1731 (7a68c3f) into main (11a6120) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1731      +/-   ##
==========================================
+ Coverage   81.17%   81.27%   +0.09%     
==========================================
  Files          78       78              
  Lines        3469     3476       +7     
==========================================
+ Hits         2816     2825       +9     
+ Misses        449      446       -3     
- Partials      204      205       +1     
Impacted Files Coverage Δ
transport/http/resolver.go 64.00% <0.00%> (-4.00%) ⬇️
transport/grpc/client.go 95.45% <0.00%> (-0.06%) ⬇️
transport/grpc/server.go 93.33% <0.00%> (+1.25%) ⬆️
transport/http/server.go 77.41% <0.00%> (+2.41%) ⬆️
internal/context/context.go 100.00% <0.00%> (+2.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11a6120...7a68c3f. Read the comment docs.

@letian0805 letian0805 requested a review from tonybase December 31, 2021 07:37
Copy link
Author

@letian0805 letian0805 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@longXboy @haiyux

@tonybase tonybase merged commit 1e749de into go-kratos:main Jan 1, 2022
@letian0805 letian0805 deleted the fix/registry_consul branch January 1, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consul服务注册和发现两个问题
3 participants