Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(log): add global logger appliance, as process level default logger #1761

Merged
merged 2 commits into from
Jan 12, 2022

Conversation

realityone
Copy link
Contributor

Description (what this PR does / why we need it):

Add global logger appliance, make logging in independence function easily.

Which issue(s) this PR fixes (resolves / be part of):

fixes #

Other special notes for reviewer:

@realityone realityone force-pushed the global-logger-appliance branch from 4648f06 to ee44d7e Compare January 11, 2022 09:31
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2022

Codecov Report

Merging #1761 (2c10e85) into main (8c9e70b) will decrease coverage by 0.01%.
The diff coverage is 43.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1761      +/-   ##
==========================================
- Coverage   81.16%   81.15%   -0.02%     
==========================================
  Files          78       79       +1     
  Lines        3420     3528     +108     
==========================================
+ Hits         2776     2863      +87     
- Misses        442      460      +18     
- Partials      202      205       +3     
Impacted Files Coverage Δ
log/global.go 35.41% <35.41%> (ø)
app.go 83.49% <100.00%> (ø)
config/config.go 55.84% <100.00%> (ø)
middleware/recovery/recovery.go 100.00% <100.00%> (ø)
transport/grpc/resolver/discovery/builder.go 85.10% <100.00%> (ø)
transport/grpc/server.go 93.33% <100.00%> (+1.25%) ⬆️
transport/http/resolver.go 64.00% <100.00%> (-4.00%) ⬇️
transport/http/server.go 77.41% <100.00%> (+2.41%) ⬆️
selector/node/ewma/node.go 83.87% <0.00%> (-3.23%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c9e70b...2c10e85. Read the comment docs.

@shenqidebaozi shenqidebaozi changed the title add global logger appliance, as process level default logger feat(logger): add global logger appliance, as process level default logger Jan 11, 2022
@shenqidebaozi shenqidebaozi changed the title feat(logger): add global logger appliance, as process level default logger feat(log): add global logger appliance, as process level default logger Jan 11, 2022
shenqidebaozi
shenqidebaozi previously approved these changes Jan 11, 2022
Copy link
Member

@shenqidebaozi shenqidebaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

log/global.go Outdated Show resolved Hide resolved
log/global.go Outdated Show resolved Hide resolved
@realityone realityone force-pushed the global-logger-appliance branch from 793f5e2 to 2c10e85 Compare January 12, 2022 04:06
@tonybase tonybase merged commit 0ed2e0f into go-kratos:main Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants