-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:proto nesting causes template generation problems #2718
Conversation
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #2718 +/- ##
==========================================
- Coverage 84.78% 84.73% -0.06%
==========================================
Files 88 88
Lines 3891 3891
==========================================
- Hits 3299 3297 -2
- Misses 418 420 +2
Partials 174 174 see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
help supplement the unit test |
Short: "Generate the proto client code", | ||
Long: "Generate the proto client code. Example: kratos proto client helloworld.proto", | ||
Short: "Generate the proto Client code", | ||
Long: "Generate the proto Client code. Example: kratos proto client helloworld.proto", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change to uppercase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smooth and consistent with Server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a hint. use
is client
?
this fix will cause google.protobuf.Empty parse failed |
后面好像有pr已经fix了 |
目前还存在这个问题 |
fix #2717