fix(contrib/registry/servicecomb): ticker was shutdown prematurely #2749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #2749 +/- ##
=======================================
Coverage 84.78% 84.78%
=======================================
Files 88 88
Lines 3891 3891
=======================================
Hits 3299 3299
Misses 418 418
Partials 174 174 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
demoManito
force-pushed
the
fix/servicecomb/ticker-close
branch
3 times, most recently
from
8e4ceb6 to
e71af04
Compare
demoManito
force-pushed
the
fix/servicecomb/ticker-close
branch
from
e71af04 to
f2c1ee7
Compare
demoManito
commented
Mar 22, 2023
| @@ -146,9 +147,9 @@ func (r *Registry) Register(_ context.Context, svcIns *registry.ServiceInstance) | |||
| if err != nil { | |||
| return err | |||
| } | |||
| ticker := time.NewTicker(30 * time.Second) | |||
| defer ticker.Stop() | |||
demoManito
changed the title
daemon365
approved these changes
Mar 23, 2023
shenqidebaozi
approved these changes
Mar 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (what this PR does / why we need it):
Which issue(s) this PR fixes (resolves / be part of):
Other special notes for the reviewers: