Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(version): upgrade some modules to go 1.19 #2905

Merged
merged 1 commit into from
Jul 28, 2023
Merged

build(version): upgrade some modules to go 1.19 #2905

merged 1 commit into from
Jul 28, 2023

Conversation

pplmx
Copy link
Contributor

@pplmx pplmx commented Jul 6, 2023

BREAKING CHANGE: upgrade go 1.19

Description (what this PR does / why we need it):

Upgrade the go submodule to go1.19

  • fixed the go.sum contains so many different versions
  • remove some deprecated linter in golangci-lint
    • The linter 'deadcode' is deprecated (since v1.49.0)
    • The linter 'varcheck' is deprecated (since v1.49.0)
    • The linter 'deadcode' is deprecated (since v1.49.0)

Which issue(s) this PR fixes (resolves / be part of):

Other special notes for the reviewers:

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2023

Codecov Report

Merging #2905 (70cc5da) into main (bffc1a0) will increase coverage by 0.07%.
The diff coverage is n/a.

❗ Current head 70cc5da differs from pull request most recent head ba5c7ae. Consider uploading reports for the commit ba5c7ae to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #2905      +/-   ##
==========================================
+ Coverage   84.43%   84.50%   +0.07%     
==========================================
  Files          88       88              
  Lines        3976     3970       -6     
==========================================
- Hits         3357     3355       -2     
+ Misses        443      439       -4     
  Partials      176      176              

see 3 files with indirect coverage changes

BREAKING CHANGE: upgrade go 1.19
@pplmx pplmx requested a review from daemon365 July 10, 2023 01:54
@pplmx
Copy link
Contributor Author

pplmx commented Jul 13, 2023

Any progress?

@shenqidebaozi shenqidebaozi merged commit 7d9a0d1 into go-kratos:main Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants