fix:polaris config watch #3082
Merged
fix:polaris config watch #3082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…articularly in situations when config events are closed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3082 +/- ##
=======================================
Coverage 84.28% 84.28%
=======================================
Files 88 88
Lines 3984 3984
=======================================
Hits 3358 3358
Misses 449 449
Partials 177 177 ☔ View full report in Codecov by Sentry. |
shenqidebaozi
previously approved these changes
Dec 3, 2023
dosubot
bot
added
the
size:XS
daemon365
previously approved these changes
Dec 4, 2023
tonybase
reviewed
Dec 4, 2023
…articularly in situations when config events are closed.
…ix/polaris_config_watch
tan-zhuo
dismissed stale reviews from daemon365 and shenqidebaozi
via
3f79526
daemon365
approved these changes
Dec 4, 2023
shenqidebaozi
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (what this PR does / why we need it):
The high CPU usage issue caused by watching the Polaris config, particularly in situations when config events are closed.
If the configuration connection has already been closed, the configuration file monitoring should be canceled.
Otherwise, the following method call will enter into an infinite loop. It is necessary to throw a connection-closed exception to cancel the monitoring.
filePath：config/config.go
filePath: contrib/polaris/config.go