Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clear err after app stop err handling #3146

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

lawlielt
Copy link
Contributor

@lawlielt lawlielt commented Jan 4, 2024

Description (what this PR does / why we need it):

clear the err after the app wait err handing, to avoid the err return when afterStop is not set.

Which issue(s) this PR fixes (resolves / be part of):

Other special notes for the reviewers:

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 4, 2024
Copy link
Member

@shenqidebaozi shenqidebaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the LGTM label Jan 4, 2024
@shenqidebaozi shenqidebaozi merged commit 34d9666 into go-kratos:main Jan 5, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants