fix(encoding/form): optimize EncodeField and add test cases #3234
Conversation
dosubot
bot
added
the
size:L
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3234 +/- ##
==========================================
+ Coverage 81.54% 81.63% +0.08%
==========================================
Files 91 91
Lines 4167 4165 -2
==========================================
+ Hits 3398 3400 +2
+ Misses 589 587 -2
+ Partials 180 178 -2 ☔ View full report in Codecov by Sentry. |
| case protoreflect.BytesKind: | ||
| return base64.URLEncoding.EncodeToString(value.Bytes()), nil | ||
| case protoreflect.MessageKind, protoreflect.GroupKind: | ||
| return encodeMessage(fieldDescriptor.Message(), value) | ||
| default: | ||
| return fmt.Sprint(value.Interface()), nil | ||
| return value.String(), nil |
There was a problem hiding this comment.
Should this be a feature or fix?
There was a problem hiding this comment.
Not a feature or fix, optimized by the way.
value.String() already contains fmt.Sprint(value.Interface()), for non-special types just use .String()
There was a problem hiding this comment.
What I'm talking about is the title issue
demoManito
force-pushed
the
test/form-encode
branch
from
117f608 to
cf064eb
Compare
demoManito
changed the title
EncodeField remove protoreflect.StringKind and supplementary encode map test cases
demoManito
changed the title
EncodeField remove protoreflect.StringKind and supplementary encode map test casesEncodeField remove protoreflect.StringKind and add encode map test cases
demoManito
changed the title
EncodeField remove protoreflect.StringKind and add encode map test casesEncodeField remove protoreflect.StringKind and add map test cases
demoManito
force-pushed
the
test/form-encode
branch
from
cf064eb to
9d25284
Compare
demoManito
changed the title
EncodeField remove protoreflect.StringKind and add map test cases
Description (what this PR does / why we need it):
remove protoreflect.StringKind convert to string
supplementary encode map test cases
Which issue(s) this PR fixes (resolves / be part of):
Other special notes for the reviewers: