fix(encoding/form): Timestamp use local time and fix test wrong mock time zone
#3257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3257 +/- ##
=======================================
Coverage 81.54% 81.54%
=======================================
Files 91 91
Lines 4167 4167
=======================================
Hits 3398 3398
Misses 589 589
Partials 180 180 ☔ View full report in Codecov by Sentry. |
demoManito
changed the title
Timestamp use local time and fix test wrong mock time zone
demoManito
changed the title
Timestamp use local time and fix test wrong mock time zoneTimestamp use local time and fix test wrong mock time zone
demoManito
commented
Mar 17, 2024
| @@ -244,7 +244,7 @@ func parseMessage(md protoreflect.MessageDescriptor, value string) (protoreflect | |||
| if value == nullStr { | |||
| break | |||
| } | |||
| t, err := time.Parse(time.RFC3339Nano, value) | |||
| t, err := time.ParseInLocation(time.RFC3339Nano, value, time.Local) | |||
There was a problem hiding this comment.
Synchronize time zone with encoding timestamp
shenqidebaozi
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (what this PR does / why we need it):
parseMessageshould also use the current time zone timeWhich issue(s) this PR fixes (resolves / be part of):
fix issue: #3181
Other special notes for the reviewers: