Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contrib/polaris): incorrect conversion between integer types #3300

Merged
merged 2 commits into from
Apr 27, 2024

Conversation

demoManito
Copy link
Member

@demoManito demoManito commented Apr 22, 2024

Description (what this PR does / why we need it):

https://github.com/go-kratos/kratos/security/code-scanning/3
image

Which issue(s) this PR fixes (resolves / be part of):

Other special notes for the reviewers:

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 22, 2024
@demoManito demoManito changed the title fix(contrib/polaris): convert string to int32 fix(contrib/polaris): incorrect conversion between integer types Apr 22, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.96%. Comparing base (f715eb0) to head (8d2db86).
Report is 7 commits behind head on main.

❗ Current head 8d2db86 differs from pull request most recent head 18d5f54. Consider uploading reports for the commit 18d5f54 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3300      +/-   ##
==========================================
+ Coverage   81.93%   81.96%   +0.03%     
==========================================
  Files          92       92              
  Lines        4206     4203       -3     
==========================================
- Hits         3446     3445       -1     
+ Misses        580      579       -1     
+ Partials      180      179       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the LGTM label Apr 24, 2024
@daemon365 daemon365 merged commit 45603e3 into go-kratos:main Apr 27, 2024
33 checks passed
@demoManito demoManito deleted the fix/strconv branch April 28, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants